Skip to content

Fix Travis CI slow build on Project Euler Solution job #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2020
Merged

Fix Travis CI slow build on Project Euler Solution job #3262

merged 2 commits into from
Oct 13, 2020

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 13, 2020 •
edited
Loading

I just noticed how long it is taking for Travis CI to run Project Euler Solution job and saw this:

I think that after the latest change, Travis used pip install -r requirements.txt to install pytest. This is to test whether that is true or not. If it is then the changes made in this PR should fix that.

Update: Installing pytest in the install step of the job fixes it.

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

@dhruvmanila dhruvmanila changed the title Fix travis ci Fix Travis CI slow build on Project Euler Solution job Oct 13, 2020
@dhruvmanila dhruvmanila marked this pull request as ready for review October 13, 2020 15:08
@dhruvmanila dhruvmanila requested a review from cclauss as a code owner October 13, 2020 15:08
@dhruvmanila
Copy link
Member Author

This fixes it: https://travis-ci.com/github/TheAlgorithms/Python/jobs/398923978#L224

@dhruvmanila dhruvmanila merged commit 34d63d5 into master Oct 13, 2020
@dhruvmanila dhruvmanila deleted the fix-travis-ci branch October 13, 2020 17:14
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila @stokhos
Fix Travis CI slow build on Project Euler Solution job (TheAlgorithms…
7112b21 
…#3262)

* Fix Travis CI long run for validate_solutions

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
Fix Travis CI slow build on Project Euler Solution job (TheAlgorithms…
e482e63 
…#3262)

* Fix Travis CI long run for validate_solutions

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @cclauss